-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the fullscreen "x" icon with a back arrow #9838
Conversation
As per comments in #9567. The `x` icon to close the editor while in fullscreen mode could be misconstrued as a button for exiting out of full screen mode. Since the button actually takes you back to the All Posts screen, a back arrow may make more sense here.
Would this also be a good candidate for a tooltip? |
@chrisvanpatten I think there's already a tooltip |
My bad! 🙈 |
I find the arrow to be an improvement over the "X", for reasons expanded upon in Slack (link requires registration). For me, it's a bit of the difference between "exit out of ..." (X) vs. "return to ..." (left arrow), where the expectation of "exit out of" would be to close full screen mode. This might be particularly true when one is simply clicking around and happens to find themselves stumbled upon the full screen mode, and then needs an escape route (as was my scenario). I think "exit out of" could work, if we were to use an icon more associated with leaving vs. closing an intermediary (full screen as a mode). I've seen "Exit" icons like these before, for example: |
Love this, and love Andrews suggestion also. |
This adds an "Exit" icon, which is used to exit fullscreen mode in Gutenberg. See discussion in WordPress/gutenberg#9838 (comment).
Added the icon to Dashicons: WordPress/dashicons#321 Added the sprite to Gutenberg in #10025 CC: @kjellr |
@jasmussen You are the absolute best. Looks great: Would someone mind giving this a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this is 👍
Ship it! |
🎉 Thanks, all! |
As per comments by @SNaushadS and others in #9567, the
x
icon in the upper left corner of fullscreen mode could be misinterpreted as a button for exiting out of full screen mode. Since the button takes you "back" to the All Posts screen, a back arrow may make more sense here.Current:
New: